lwtdev edited a comment on pull request #8740: URL: https://github.com/apache/shardingsphere/pull/8740#issuecomment-750354646
> It is unnecessary to change the package name, can you revert that? @terrymanu Rename `impl.expr` to `impl.expression` is in order to be consistent with the name under `asserts.segment` (`org.apache.shardingsphere.test.sql.parser.parameterized.asserts.segment.expression`). Maybe I should rename `asserts.segment.expression` to `asserts.segment.expr`? Becasue `ExpressionSegment` is under package `org.apache.shardingsphere.sql.parser.sql.common.segment.dml.expr`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
