terrymanu commented on PR #37429:
URL: https://github.com/apache/shardingsphere/pull/37429#issuecomment-3677916926
Here’s a consolidated note to help land the next revision:
- The implementation still stops at “parse succeeds / returns empty set”;
it doesn’t address the core need of returning real SHOW TRANSACTION
data—executor ignores FROM/WHERE and isn’t wired to any transaction/load-job
source.
- The returned columns don’t match the Doris protocol (missing
Coordinator, LoadJobSourceType, PrepareTime/CommitTime, etc.), so clients may
break.
- Tests only cover empty data and metadata shape; they don’t cover real
data, filter hit/miss, or column name/type assertions—so the bugs stay hidden.
Next steps:
1. Wire to real data (or explicitly raise “not supported” instead of a
silent empty set) and honor FROM/WHERE filters.
2. Align column definitions (order and types) with Doris SHOW TRANSACTION.
3. Add tests for a data row, ID/label filter hit/miss, and column
name/type assertions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
