ccxxxyy commented on PR #37429: URL: https://github.com/apache/shardingsphere/pull/37429#issuecomment-3677341650
@terrymanu Hi, I have made the modifications as required. Hope you can review them when you have a moment. Regarding the third point of the modification suggestion, I hope you can take a look at my thoughts: Based on the official Doris [documentation](https://doris.apache.org/zh-CN/docs/4.x/sql-manual/sql-statements/transaction/SHOW-TRANSACTION) , the concern about "array literal → ListExpression" is mainly theoretical. The WHERE clause of SHOW TRANSACTION only supports simple equality comparisons, and the right side of the WHERE clause is just a simple literal (LiteralExpressionSegment). According to the Doris official [documentation ](https://doris.apache.org/zh-CN/docs/4.x/sql-manual/sql-statements/transaction/SHOW-TRANSACTION)and our implementation: The WHERE clause must use the form of id = <value> or label = <value>; it does not support complex expressions such as IN, ANY, or array literals; the parser correctly parses the WHERE clause as a simple binary comparison. Existing tests have fully verified the behavior of SHOW TRANSACTION: -- ✅ Supported syntax (binary equality comparison) SHOW TRANSACTION WHERE id = 4005 SHOW TRANSACTION WHERE label = 'test_label' SHOW TRANSACTION FROM db WHERE id = 4005 -- ❌ Unsupported syntax SHOW TRANSACTION WHERE id IN (4005, 4006, 4007) -- IN clause not supported SHOW TRANSACTION WHERE id = ANY [4005, 4006] -- Arrays not supported SHOW TRANSACTION WHERE (id, label) = (4005, 'x') -- Tuple comparison not supported -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
