linghengqian commented on code in PR #37421:
URL: https://github.com/apache/shardingsphere/pull/37421#discussion_r2629934072


##########
docs/document/content/user-manual/shardingsphere-jdbc/optional-plugins/clickhouse/_index.en.md:
##########
@@ -170,27 +170,15 @@ public class ExampleUtils {
 
 ShardingSphere JDBC DataSource does not yet support executing ClickHouse's 
`create table`, `truncate table`,
 and `drop table` statements.
-Users should consider submitting a PR containing unit tests for ShardingSphere.
+The current ShardingSphere parsing of ClickHouse's `INNER JOIN` syntax has 
shortcomings, 
+and may return incorrect query results for SQL statements such as `SELECT i.* 
FROM t_order o, t_order_item i WHERE o.order_id = i.order_id`.

Review Comment:
   I don't think we need to worry about the text syntax issues in the comments; 
they're temporary.



##########
docs/document/content/user-manual/shardingsphere-jdbc/optional-plugins/clickhouse/_index.cn.md:
##########
@@ -167,24 +167,14 @@ public class ExampleUtils {
 ### SQL 限制
 
 ShardingSphere JDBC DataSource 尚不支持执行 ClickHouse 的 `create table`,`truncate 
table` 和 `drop table` 语句。
-用户应考虑为 ShardingSphere 提交包含单元测试的 PR。
+当前 ShardingSphere 对 ClickHouse 的 `INNER JOIN` 语法解析存在不足,
+对 `SELECT i.* FROM t_order o, t_order_item i WHERE o.order_id = i.order_id` 这类 
SQL 可能返回错误的查询结果。

Review Comment:
   I don't think we need to worry about the text syntax issues in the comments; 
they're temporary.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to