linghengqian commented on code in PR #37421: URL: https://github.com/apache/shardingsphere/pull/37421#discussion_r2629933482
########## docs/document/content/user-manual/shardingsphere-jdbc/optional-plugins/hiveserver2/_index.en.md: ########## @@ -372,9 +372,9 @@ Reference https://issues.apache.org/jira/browse/HIVE-28418 . ### SQL Limitations -HiveServer2 does not guarantee that every `insert` related DML SQL can be executed successfully, although no exception may be thrown. - ShardingSphere JDBC DataSource does not yet support executing the `set` statement of HiveServer2. +The current ShardingSphere parsing of HiveServer2's `INNER JOIN` syntax has shortcomings, +and may return incorrect query results for SQL statements such as `SELECT i.* FROM t_order o, t_order_item i WHERE o.order_id = i.order_id`. Review Comment: I don't think we need to worry about the text syntax issues in the comments; they're temporary. ########## docs/document/content/user-manual/shardingsphere-jdbc/optional-plugins/hiveserver2/_index.cn.md: ########## @@ -366,9 +366,9 @@ ShardingSphere 仅针对 HiveServer2 `4.0.1` 进行集成测试。 ### SQL 限制 -HiveServer2 并不能保证每一条 `insert` 相关的 DML SQL 都能成功执行，尽管可能没有任何异常被抛出。 - ShardingSphere JDBC DataSource 尚不支持执行 HiveServer2 的 `set` 语句。 +当前 ShardingSphere 对 HiveServer2 的 `INNER JOIN` 语法解析存在不足， +对 `SELECT i.* FROM t_order o, t_order_item i WHERE o.order_id = i.order_id` 这类 SQL 可能返回错误的查询结果。 Review Comment: I don't think we need to worry about the text syntax issues in the comments; they're temporary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
