Copilot commented on code in PR #37401:
URL: https://github.com/apache/shardingsphere/pull/37401#discussion_r2622416517
##########
test/native/src/test/java/org/apache/shardingsphere/test/natived/commons/repository/AddressRepository.java:
##########
@@ -97,6 +97,21 @@ public void createAcidTableInHiveServer2() throws
SQLException {
}
}
+ /**
+ * Create Iceberg table in HiveServer2.
+ *
+ * @throws SQLException SQL exception
+ */
+ public void createIcebergTableInHiveServer2() throws SQLException {
+ String sql = "CREATE TABLE IF NOT EXISTS t_address (address_id BIGINT
NOT NULL,address_name string NOT NULL,"
Review Comment:
This string appears to be missing a space after 'NULL,'.
```suggestion
String sql = "CREATE TABLE IF NOT EXISTS t_address (address_id
BIGINT NOT NULL,address_name string NOT NULL, "
```
##########
test/native/src/test/java/org/apache/shardingsphere/test/natived/commons/repository/OrderItemRepository.java:
##########
@@ -118,6 +118,23 @@ public void createAcidTableInHiveServer2() throws
SQLException {
}
}
+ /**
+ * create Iceberg table in HiveServer2.
+ * Hive does not support `AUTO_INCREMENT`,
+ * refer to <a
href="https://issues.apache.org/jira/browse/HIVE-6905";>HIVE-6905</a>.
+ *
+ * @throws SQLException SQL exception
+ */
+ public void createIcebergTableInHiveServer2() throws SQLException {
+ String sql = "CREATE TABLE IF NOT EXISTS t_order_item (order_item_id
BIGINT NOT NULL,order_id BIGINT NOT NULL,user_id INT NOT NULL,phone
string,status string,"
Review Comment:
This string appears to be missing a space after 'string,'.
```suggestion
String sql = "CREATE TABLE IF NOT EXISTS t_order_item (order_item_id
BIGINT NOT NULL,order_id BIGINT NOT NULL,user_id INT NOT NULL,phone
string,status string, "
```
##########
test/native/src/test/java/org/apache/shardingsphere/test/natived/commons/repository/OrderRepository.java:
##########
@@ -114,6 +114,23 @@ public void createAcidTableInHiveServer2() throws
SQLException {
}
}
+ /**
+ * Create Iceberg table in HiveServer2.
+ * Hive does not support `AUTO_INCREMENT`,
+ * refer to <a
href="https://issues.apache.org/jira/browse/HIVE-6905";>HIVE-6905</a>.
+ *
+ * @throws SQLException SQL exception
+ */
+ public void createIcebergTableInHiveServer2() throws SQLException {
+ String sql = "CREATE TABLE IF NOT EXISTS t_order (order_id BIGINT NOT
NULL,order_type INT,user_id INT NOT NULL,address_id BIGINT NOT NULL,status
string,"
Review Comment:
This string appears to be missing a space after 'string,'.
```suggestion
String sql = "CREATE TABLE IF NOT EXISTS t_order (order_id BIGINT
NOT NULL, order_type INT, user_id INT NOT NULL, address_id BIGINT NOT NULL,
status string, "
```
##########
test/native/src/test/java/org/apache/shardingsphere/test/natived/commons/repository/OrderItemRepository.java:
##########
@@ -118,6 +118,23 @@ public void createAcidTableInHiveServer2() throws
SQLException {
}
}
+ /**
+ * create Iceberg table in HiveServer2.
Review Comment:
Inconsistent capitalization in JavaDoc. The word "create" should be
capitalized at the beginning of the sentence to match the style used in
OrderRepository (line 118) and AddressRepository (line 101).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
