ShenFeng312 commented on PR #36372: URL: https://github.com/apache/shardingsphere/pull/36372#issuecomment-3580477211
> 3\. There are clearly incorrect parts of the business logic, such as `PostgreSQLStringBinaryProtocolValue#write`. For performance considerations, I believe it's reasonable to return -1 when the length cannot be determined, and then obtain the value when writing. I have noted the reason for the change in the interface. If we convert the string into a byte array just to get its length, I think that’s a waste of performance. It's completely unnecessary, because when writing we already obtain its byte array anyway @RaigorJiang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
