ShenFeng312 commented on PR #36372: URL: https://github.com/apache/shardingsphere/pull/36372#issuecomment-3573970554
> Hi @ShenFeng312 > > I discussed this with several committers familiar with the Proxy protocol, and we reached the following consensus: > > 1. The current PR involves too many changes, including adjustments to data processing logic and abstraction levels, making review difficult; > 2. The code has many non-standard aspects, including naming conventions and comments; > 3. There are clearly incorrect parts of the business logic, such as `PostgreSQLStringBinaryProtocolValue#write`. > > Based on the above information, we speculate that some code in this PR was generated by a large model? Some code appears to have not been rigorously considered. > > Therefore, we suggest you withdraw this PR and submit it multiple times with small-scale adjustments, ensuring the correctness of the code logic and comments, as well as consistency in style. I don't think you have carefully reviewed this PR. The serialization and deserialization logic for arrays in this PR comes from part of the code in pgjdbc. I have abstracted and optimized it to support both binary and text formats. As a result, it carries the coding style of pg-jdbc. @RaigorJiang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
