sindhunaydu commented on issue #28035: URL: https://github.com/apache/shardingsphere/issues/28035#issuecomment-1683440328
> > Hi All, thanks for assigning this task to me, I'm very new to all of this and would like some guidance and suggestions. I have been looking into the documentation and have a some questions, > > > > 1. do I need to modify the existing INDEX_META_DATA_SQL or add a new String? > > 2. the [H2 documentation](https://www.h2database.com/html/systemtables.html#information_schema_indexes) shows that the name of the unique index is UNIQUE INDEX. I don't see any column field in the H2 docs. Do I need to only add UNIQUE INDEX? > > 3. do I also need to add new PreparedStatement logic in loadIndexMetaDataMap() as well? > > > > Thanks! > > 1. Don't need a new String, I think use `INDEX_META_DATA_SQL` directly. > 2. use `UNIQUE INDEX` is OK. > 3. no need, use `loadIndexMetaDataMap()` directly. @dongzl thanks for the info. I made the changes and ran the H2MetaDataLoaderTest locally and the tests passed. when I ran the `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e` command the `YamlEngineTest` tests (3 tests are failing) are failing with the following error message - `java.nio.file.NoSuchFileException: /../shardingsphere/infra/util/target/test-classes/yaml/shortcuts-fixture.yaml` I do see the file in that specific location, yet the test is saying that file does not exist. Have you seen this error before? Am I missing anything? I was able to build the app locally using [this command](https://github.com/apache/shardingsphere/wiki#build-apache-shardingsphere) successfully - `./mvnw clean install -Prelease -T1C -DskipTests -Djacoco.skip=true -Dcheckstyle.skip=true -Drat.skip=true -Dmaven.javadoc.skip=true -B` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
