mdedetrich commented on PR #2460: URL: https://github.com/apache/pekko/pull/2460#issuecomment-3508206231
> @mdedetrich @raboof Is it just the asJavaSubscriber and asJavaProducer that is causing concerns? > > If I separate out those changes but keep the moves of the fromPublisher and fromSubscriber methods, is that ok? Those methods can be overloaded because they don't hit issues with generics and type erasure. For me the design is cleaner to have `asSubscriber`/`asPublisher` and `fromSubscriber`/`fromPublisher` method names reused for both reactive streams and Java flow and just have different FQN (including the object), i.e. `pekko.stream.JavaFlow.asSubscriber` vs `pekko.stream.ReactiveStreams.asSubscriber`. If the design is breaking with Pekko 1.3.x you can create alias methods in Pekko 1.3.x that point to the new design in 2.0.0 and deprecate the older ones (Pekko 1.3.x hasn't been released yet). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
