mdedetrich commented on PR #2230: URL: https://github.com/apache/pekko/pull/2230#issuecomment-3311135853
> I cannot agree with using `SortImports` scalafix rule, because it is no longer actively maintained and is deprecated in favor of `OrganizeImports`. Because applying either `SortImports` or `OrganizeImports` will produce a large changeset anyways, I think we should use it as an opportunity to migrate to a newer rule. > > I also think that a PR that organizes imports should also include changes to CI jobs that will actually enforce the newly applied organization. > > And lastly, import organization could be done in a patch release, because it does not change behavior of the code. If we come to a decision, I will likely create the final PR as it has to be setup in an extremely specific way and also as you said a ci check needs to be added to check that imports have been run with scalafix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
