raboof commented on PR #1980: URL: https://github.com/apache/pekko/pull/1980#issuecomment-3139130907
> > > Should this also include a note in https://pekko.apache.org/docs/pekko/current/common/binary-compatibility-rules.html that, for the purpose of binary compatibility, we should consider all methods that are called by inline functions that are part of the public API as 'public API' as well, even if MiMa won't warn about them? > > > > > > These are all internal API functions, none of them are meant to be called outside of pekko and this part is remarked in https://pekko.apache.org/docs/pekko/current/common/binary-compatibility-rules.html#the-internal-api-and-marker. > > Or am I missing something? > > Ah, I didn't realize, no problem then 👍 Oh, some are `@InternalStableApi`, meaning they may get called by satellite projects, meaning they need to be de-facto binary compatible. We should probably document that _somewhere_ to remind our future selves I think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
