mdedetrich opened a new pull request, #1980: URL: https://github.com/apache/pekko/pull/1980
In https://github.com/apache/pekko/pull/1079 we had to remove the Scala 3 inline keyword because it technically broke backwards compatibility (in short, the scala 3 inline keyword prevents that method from being called in Java, see https://github.com/lampepfl/dotty/issues/19346 and https://contributors.scala-lang.org/t/can-we-still-generate-bytecode-when-inline-def-method-been-called-from-java/6500). This PR adds back the Scala 3 inline keyword for the Pekko 2.0.x series since breaking changes are allowed. Note that the Scala 3 inline keyword is _**ONLY**_ being added for methods which are to be called within Scala 3 and _**NOT**_ Java (the conversion util methods have already been split up between methods called from Scala and methods called from Java due to https://github.com/apache/pekko/pull/894 and as a result there isn't a single section in the entire pekko codebase where Java source calls these Scala methods) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
