jypma commented on PR #1002: URL: https://github.com/apache/pekko-connectors/pull/1002#issuecomment-2724010709
Unfortunately, the size addition in this PR turned out to be a red herring. `getSize()` on `ZipInputStream` apparently happily returns -1, even though the size is known in the Zip TOC. I'm seeing what's also reported [here](https://stackoverflow.com/questions/36045421/java-zipentry-getsize-returns-1). Additionally, it seems that unfortunately currently there are no tests for the "unzipping" part that's modified here. `ZipArchiveFlowTest` seems to test the creation of ZIP files, where we wouldn't even want the user to report a size. I'm closing this PR for now, as I've had to rewrite my code in terms of `ZipFile` anyway (instead of `ZipInputStream`), which does report size correctly. If I find the time at some point, I could help out with a re-implementation around `ZipFile` (which also seems to be more friendly in arbitrarily seeking in a ZIP file). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
