raboof commented on code in PR #1002:
URL: https://github.com/apache/pekko-connectors/pull/1002#discussion_r1988720154
##########
file/src/main/scala/org/apache/pekko/stream/connectors/file/model.scala:
##########
@@ -25,11 +25,13 @@ object ArchiveMetadata {
def create(filePath: String): ArchiveMetadata = new ArchiveMetadata(filePath)
}
-final case class ZipArchiveMetadata(name: String) {
+final case class ZipArchiveMetadata(name: String, size: Long,
lastModification: Instant) {
Review Comment:
this seems like it'd not be binary compatible, because of the generated
methods for case classes that would change - I'm not sure if it's possible to
manually 'add back' the original methods to restore binary compatibility?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
