pjfanning commented on code in PR #1776:
URL: https://github.com/apache/pekko/pull/1776#discussion_r1973417331
##########
stream/src/main/scala/org/apache/pekko/stream/stage/GraphStage.scala:
##########
@@ -1118,6 +1139,19 @@ abstract class GraphStageLogic private[stream] (val
inCount: Int, val outCount:
}
}
+ private final class EmittingSpliterator[T](_out: Outlet[T], elems:
Spliterator[T], _previous: OutHandler,
Review Comment:
I'm not sure this will make a big diff to performance. I'll approve this but
without jmh bechmarks, I am very sceptical about whether this extra code is
worth the extra maintenance overhead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
