pjfanning commented on code in PR #1776:
URL: https://github.com/apache/pekko/pull/1776#discussion_r1973305579


##########
stream/src/main/scala/org/apache/pekko/stream/stage/GraphStage.scala:
##########
@@ -1118,6 +1139,19 @@ abstract class GraphStageLogic private[stream] (val 
inCount: Int, val outCount:
     }
   }
 
+  private final class EmittingSpliterator[T](_out: Outlet[T], elems: 
Spliterator[T], _previous: OutHandler,

Review Comment:
   * the advantage of a Spliterator over an iterator is that you can use 
trySplit() to partition the workload so you can get multiple threads to work on 
the data
   * if you just use tryAdvance, you might as well be just using the standard 
iterator]
   * so what do we gain here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org

Reply via email to