raboof commented on code in PR #615:
URL: https://github.com/apache/pekko-http/pull/615#discussion_r1792167324


##########
build.sbt:
##########
@@ -22,6 +22,7 @@ import 
com.lightbend.paradox.apidoc.ApidocPlugin.autoImport.apidocRootPackage
 sourceDistName := "apache-pekko-http"
 sourceDistIncubating := false
 
+ThisBuild / resolvers += Resolver.ApacheMavenSnapshotsRepo

Review Comment:
   I agree it's useful to be able to test against artifacts in the snapshots 
repo, but I'm not sure I'm a fan of having it enabled by default even when not 
testing snapshots - it adds some overhead, makes error messages harder to read, 
and is a possible attack vector.
   
   Could we have it but commented-out, so we can easily enable it when the 
situation calls for it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to