pjfanning commented on code in PR #615: URL: https://github.com/apache/pekko-http/pull/615#discussion_r1792153544
########## build.sbt: ########## @@ -22,6 +22,7 @@ import com.lightbend.paradox.apidoc.ApidocPlugin.autoImport.apidocRootPackage sourceDistName := "apache-pekko-http" sourceDistIncubating := false +ThisBuild / resolvers += Resolver.ApacheMavenSnapshotsRepo Review Comment: The point of sbt-pekko-build and our classes built on it like PekkoCoreDependency.scala is to allow us to test with snapshot versions of our modules. This has proved invaluable in the past. Without this resolver setup - which you will find in most other Pekko build files - this snapshot build support breaks and then we don't need sbt-pekko-build anymore and might as well remove all the build config overhead that it adds. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
