Roiocam commented on code in PR #1388:
URL: https://github.com/apache/pekko/pull/1388#discussion_r1721164714
##########
actor-typed-tests/src/test/scala/org/apache/pekko/actor/typed/SupervisionSpec.scala:
##########
@@ -401,40 +411,16 @@ class SupervisionSpec extends
ScalaTestWithActorTestKit("""
throw new Exc3()
targetBehavior(probe.ref)
})
- val behv =
Behaviors.supervise(failedSetup).onFailure[Throwable](SupervisorStrategy.stop)
+ val behv =
supervise(failedSetup).onFailure[Throwable](SupervisorStrategy.stop)
LoggingTestKit.error[Exc3].expect {
spawn(behv)
}
}
- "support nesting exceptions with different strategies" in {
+ def throwIOExceptionThenIllegalArgumentException(behvFactory:
ActorRef[Event] => Behavior[Command]): Unit = {
Review Comment:
`"support nesting exceptions with outer restart and inner backoff
strategies" in {`
and
`"support nesting exceptions with different strategies" in {`
almost same, Therefore, it is compressed into the same method here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
