pjfanning commented on code in PR #1388:
URL: https://github.com/apache/pekko/pull/1388#discussion_r1721035997
##########
actor-typed-tests/src/test/scala/org/apache/pekko/actor/typed/SupervisionSpec.scala:
##########
@@ -1232,34 +1222,33 @@ class SupervisionSpec extends
ScalaTestWithActorTestKit("""
"work with nested supervisions and defers" in {
val strategy = SupervisorStrategy.restart.withLimit(3, 1.second)
val probe = TestProbe[AnyRef]("p")
- val beh = supervise[String](setup(_ =>
- supervise[String](setup { _ =>
- probe.ref ! Started
- Behaviors.empty[String]
-
}).onFailure[RuntimeException](strategy))).onFailure[Exception](strategy)
+ val behv = supervise[String](setup { _ =>
Review Comment:
Would it make sense to also test the old way too? We should have regression
testing of old behavior too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
