Roiocam commented on PR #1271: URL: https://github.com/apache/pekko/pull/1271#issuecomment-2048855288
> DurableStateStoreException is final. I guess it can be changed to be non-final but it also is in a package called 'internal'. Fair to me. > There is an argument that the new exceptions are internal too - but anyone who writes their own persistence implementation (and there are ecosystem libs out there) would ideally need to start throwing the new exceptions in their code. So having an 'internal' class is messy. Maybe it won't be messy? plugin developer can write their own exceptions, that's fine, but in the end, those exceptions will be converted to DurableStateStoreException for the supervisor's purpose(we have to make sure that). for pekko-core change, we should be restrained. Different plugins may have exceptions independent of the specific situation of the plugin, so there is a general entry, similar to DurableStateStoreException, which will be very good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
