pjfanning commented on PR #1271: URL: https://github.com/apache/pekko/pull/1271#issuecomment-2048848306
> > > The module `persistence` mostly declared data access related, Who will directly come into contact with these exceptions? is a user or the pekko developer? If it is a user, then these exceptions should be placed in `persistence-typed`. > > > If these exceptions will be used by `DurableStateBehavior`, it should extend from `DurableStateStoreException` > > > https://github.com/apache/pekko/blob/1f20fa4aba841365f3fe9021b6f2f767d0139ff0/persistence-typed/src/main/scala/org/apache/pekko/persistence/typed/state/internal/DurableStateBehaviorImpl.scala#L156 > > > > > > DurableStateStoreException is for issues when saving state. > > I won't come to a conclusion so early. As the code below shows, they are not all of `saving state` > > https://github.com/apache/pekko/blob/1f20fa4aba841365f3fe9021b6f2f767d0139ff0/persistence-typed/src/main/scala/org/apache/pekko/persistence/typed/state/internal/Recovering.scala#L133-L135 > > > These new exceptions are for issues deleting state - see [#1233 (comment)](https://github.com/apache/pekko/discussions/1233#discussioncomment-8975620) > > We can treat DurableStateStoreException as a parent, as it is named. > > otherwise, the **supervisionStrategy won't work**(that's what I most care about). Or we can add a new supervisionStrategy via the chain, but we already have a unified entry, doesn't it? DurableStateStoreException is final. I guess it can be changed to be non-final but it also is in a package called 'internal'. There is an argument that the new exceptions are internal too - but anyone who writes their own persistence implementation (and there are ecosystem libs out there) would ideally need to start throwing the new exceptions in their code. So having an 'internal' class is messy. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
