mdedetrich commented on code in PR #44:
URL:
https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44#discussion_r1516070913
##########
core/src/main/mima-filters/1.1.x.backwards.excludes/slick.backwards.excludes:
##########
@@ -5,3 +5,38 @@
ProblemFilters.exclude[MissingTypesProblem]("org.apache.pekko.persistence.jdbc.s
ProblemFilters.exclude[MissingTypesProblem]("org.apache.pekko.persistence.jdbc.snapshot.dao.legacy.SnapshotTables$SnapshotRow$")
ProblemFilters.exclude[MissingTypesProblem]("org.apache.pekko.persistence.jdbc.state.DurableStateTables$DurableStateRow$")
ProblemFilters.exclude[FinalMethodProblem]("org.apache.pekko.persistence.jdbc.state.scaladsl.JdbcDurableStateStore.queries")
+ProblemFilters.exclude[IncompatibleSignatureProblem]("org.apache.pekko.persistence.jdbc.db.EagerSlickDatabase.unapply")
Review Comment:
Oh I see what you mean, `slick.backwards.excludes` [already exists
](https://github.com/apache/incubator-pekko-persistence-jdbc/blob/main/core/src/main/mima-filters/1.1.x.backwards.excludes/slick.backwards.excludes).
This is however an oversight because if you read the currently existing
`slick.backwards.excludes` you can see that its referring the Scala 3 update
which the previous version of pekko-persistence-jdbc 1.0.x never had so I think
it was somehow accidentally committed when it shouldn't have been, see this
commit
https://github.com/apache/incubator-pekko-persistence-jdbc/commit/86923ecff2543ea3e31cd8b794fb184bb3957bef
(you wanted me to merge a preparation Scala 3 PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
