mdedetrich commented on code in PR #44:
URL:
https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44#discussion_r1516067662
##########
core/src/main/mima-filters/1.1.x.backwards.excludes/slick.backwards.excludes:
##########
@@ -5,3 +5,38 @@
ProblemFilters.exclude[MissingTypesProblem]("org.apache.pekko.persistence.jdbc.s
ProblemFilters.exclude[MissingTypesProblem]("org.apache.pekko.persistence.jdbc.snapshot.dao.legacy.SnapshotTables$SnapshotRow$")
ProblemFilters.exclude[MissingTypesProblem]("org.apache.pekko.persistence.jdbc.state.DurableStateTables$DurableStateRow$")
ProblemFilters.exclude[FinalMethodProblem]("org.apache.pekko.persistence.jdbc.state.scaladsl.JdbcDurableStateStore.queries")
+ProblemFilters.exclude[IncompatibleSignatureProblem]("org.apache.pekko.persistence.jdbc.db.EagerSlickDatabase.unapply")
Review Comment:
@pjfanning In any case I have re-regenerated the
`core/src/main/mima-filters/1.1.x.backwards.excludes/slick.backwards.excludes`
file to only contain the bare necessary slick excludes that MiMa complains
about
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]