vicwicker commented on code in PR #1957:
URL: https://github.com/apache/libcloud/pull/1957#discussion_r1343874253
##########
libcloud/compute/drivers/azure_arm.py:
##########
@@ -912,6 +917,19 @@ def destroy_node(
raise
time.sleep(10)
+ # Optionally destroy the OS managed disk
+ managed_disk =
node.extra["properties"]["storageProfile"]["osDisk"].get("managedDisk")
Review Comment:
You're right. I didn't find anywhere on Azure documentation the properties
are always there so I fell back to your proposal to make it safer. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
