Kami commented on code in PR #1957: URL: https://github.com/apache/libcloud/pull/1957#discussion_r1341757191
########## libcloud/compute/drivers/azure_arm.py: ########## @@ -808,6 +808,7 @@ def destroy_node( ex_destroy_vhd=True, ex_poll_qty=10, ex_poll_wait=10, + ex_destroy_os_disk=False, Review Comment: I think it's fine to default it to `True` as long as that change is documented well (including an example of how to set it to `False`) in `docs/upgrade_notes.rst` file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@libcloud.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org