ricardobranco777 commented on PR #1944:
URL: https://github.com/apache/libcloud/pull/1944#issuecomment-1689573005

   > The change looks good to me, but can you add a a couple of simple unit 
tests for it so we can get it merged?
   
   Done.
   
   > It seems like that for consistency reasons, `libcloud.container.Type` 
should eventually be made to inherit from `libcloud.common.type`.
   
   I'm very much in favour of doing that if we remove the dunder methods.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to