ricardobranco777 opened a new pull request, #1944: URL: https://github.com/apache/libcloud/pull/1944
## Make classes inheriting from Type hashable ### Description Attributes of classes that inherit from `libcloud.common.types.Type` are not hashable, so they can't be tested for membership in sets, unlike `libcloud.container.types.Type` which works. ``` $ python Python 3.11.4 (main, Jun 9 2023, 07:59:55) [GCC 12.3.0] on linux Type "help", "copyright", "credits" or "license" for more information. >>> from libcloud.compute.types import NodeState >>> NodeState.RUNNING running >>> NodeState.RUNNING in {"running"} False >>> str(NodeState.RUNNING) in {"running"} True >>> from libcloud.container.types import Provider >>> Provider.DUMMY in {"dummy"} True ``` ### Status done, ready for review. ### Checklist (tick everything that applies) - [ ] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks) - [ ] Documentation - [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html) - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@libcloud.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org