pan3793 commented on code in PR #7663:
URL: https://github.com/apache/kyuubi/pull/7663#discussion_r3935280339


##########
kyuubi-common/src/main/scala/org/apache/kyuubi/util/ThreadUtils.scala:
##########
@@ -26,29 +27,70 @@ import org.apache.kyuubi.{KyuubiException, Logging}
 
 object ThreadUtils extends Logging {
 
-  def newBoundedVirtualThreadPerTaskExecutor(
-      maxConcurrentTasks: Int,
-      threadNamePrefix: String): ExecutorService = {
-    require(maxConcurrentTasks > 0, "maxConcurrentTasks must be positive")
-    new BoundedExecutorService(
-      newVirtualThreadPerTaskExecutor(threadNamePrefix),
-      maxConcurrentTasks)
+  trait ExecutorServiceWithMetrics extends ExecutorService {
+    def getPoolSize: Int
+    def getActiveCount: Int
+    def getQueueSize: Int
+  }
+
+  def isVirtualThreadSupported: Boolean = {

Review Comment:
   lazy val ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to