pan3793 commented on code in PR #7663:
URL: https://github.com/apache/kyuubi/pull/7663#discussion_r3932552895
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala:
##########
@@ -635,6 +635,19 @@ object KyuubiConf {
.immutable
.fallbackConf(FRONTEND_BIND_PORT)
+ val SERVER_VIRTUAL_THREADS_ENABLED: ConfigEntry[Boolean] =
+ buildConf("kyuubi.server.virtualThreads.enabled")
+ .doc("Whether to use virtual threads by default for all supported
executors in the " +
+ "Kyuubi server. This requires Java 21 or later. Enabling this option
is recommended for " +
+ "I/O-bound Kyuubi Server deployments on Java 25 or later. On Java 21,
enable virtual " +
+ "threads selectively after validating synchronized blocking paths for
carrier-thread " +
+ "pinning. An explicitly configured component-level virtual thread
option takes precedence.")
Review Comment:
shorten the words for the Java version requirement to:
Requires at least Java 21; Java 25 or later is recommended.
also apply this to all component-level configs docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
