maomaodev commented on code in PR #7476:
URL: https://github.com/apache/kyuubi/pull/7476#discussion_r3788109016
##########
extensions/spark/kyuubi-spark-connector-hive/src/test/scala/org/apache/kyuubi/spark/connector/hive/DynamicPartitionPruningSuite.scala:
##########
@@ -86,19 +85,32 @@ class DynamicPartitionPruningSuite extends KyuubiHiveTest {
| WHERE d.tag = 'target'
|""".stripMargin
+ val df = spark.sql(sql)
checkAnswer(
- spark.sql(sql),
+ df,
Seq(
Row(3, "c", "2026-05-01"),
Row(4, "d", "2026-05-01")))
// DPP being actually applied is observable as a
`DynamicPruningExpression`
// injected into `BatchScanExec.runtimeFilters`.
- val exec = findBatchScanExec(spark, sql, fact.split('.').last)
+ val exec = findBatchScanExec(df.queryExecution.executedPlan,
fact.split('.').last)
Review Comment:
Fixed in `DynamicPartitionPruningSuite`:
* Added a strict `plannedPartitions(on)` < `plannedPartitions(off)`
assertion, so the test now proves DPP actually prunes partitions instead of
only observing the `DynamicPruningExpression` node.
* Added a `columnarSupportMode()` assertion per scan type:` SUPPORTED` for
`KyuubiOrcScan` / `KyuubiParquetScan`, `UNSUPPORTED` for `HiveScan`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
