maomaodev commented on PR #7476: URL: https://github.com/apache/kyuubi/pull/7476#issuecomment-5299710953
> I'll rebase on master Thanks a lot @LuciferYang for the incredibly detailed review! The comments spanned ecosystem impact, correctness, test coverage, and maintainability — each one hit a real issue and made the patch materially better. I've pushed a new revision that addresses every code-level comment; happy to iterate on any of them. The revision is rebased onto the latest `master`, since #7631 (thanks @pan3793 ) dropped Spark 3.3 / 3.4 support, a few earlier comments that targeted the pre-3.5 compat shims resolve naturally with the rebase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
