yikf commented on PR #7622: URL: https://github.com/apache/kyuubi/pull/7622#issuecomment-5266258116
Thanks @pan3793, you're right — Hive's `moveFile(..., replace=true)` already covers this, so the guard never fires with bundled Hive 2.3.10. My intent was to make the alignment self-sufficient rather than rely on that fallback, and since it's harmless I kept it. But you're right the behavior isn't observable, so the test can't cover it — I've dropped it. I also took your `createTable` suggestion: expose the requested order only through the V2 `Table.schema()` via `requestedSchema` on `HiveTable`, leaving `catalogTable` untouched. Thanks for the detailed review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
