ruanwenjun commented on code in PR #7527:
URL: https://github.com/apache/kyuubi/pull/7527#discussion_r3540936291


##########
kyuubi-hive-jdbc/src/main/java/org/apache/kyuubi/jdbc/hive/KyuubiConnection.java:
##########
@@ -79,6 +80,7 @@ public class KyuubiConnection implements SQLConnection, 
KyuubiLoggable {
   public static final Logger LOG = 
LoggerFactory.getLogger(KyuubiConnection.class.getName());
   public static final String BEELINE_MODE_PROPERTY = "BEELINE_MODE";
   public static final String HS2_PROXY_USER = "hive.server2.proxy.user";
+  private static final String SQL_STATE_LAUNCH_ENGINE_CANCELED = "01000";

Review Comment:
   Addressed in 6ff3e96ef. Changed launch-engine cancellation from 
warning-class `01000` to error-class `57014`, and added a regression test for 
`CANCELED_STATE` in `waitLaunchEngineToComplete`.
   
   Verified with:
   - `./build/mvn -pl kyuubi-hive-jdbc -am spotless:apply`
   - `./build/mvn -pl kyuubi-hive-jdbc -am 
-Dtest=KyuubiConnectionTest,KyuubiStatementTest,TestJdbcDriver,TestKyuubiPreparedStatement,UtilsTest,ZooKeeperHiveClientHelperTest
 -DwildcardSuites=none test`
   - `git diff --check`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to