wangzhigang1999 commented on PR #7527:
URL: https://github.com/apache/kyuubi/pull/7527#issuecomment-4844694968
LGTM 👍
Just a nit (non-blocking): isInterrupted(Throwable) and the test's
hasCause(...) both hand-roll a cause-chain walk. Since commons-lang3 is already
a dependency here (this file already imports StringUtils/ClassUtils from it),
we could reuse ExceptionUtils and drop both helpers:
```java
// import org.apache.commons.lang3.exception.ExceptionUtils;
ExceptionUtils.indexOfType(e, InterruptedException.class) >= 0
```
Same semantics, ~20 fewer lines, removes the duplicated logic between main
and test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
