Sunwoo-Shin commented on code in PR #7519:
URL: https://github.com/apache/kyuubi/pull/7519#discussion_r3439928218
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSessionImpl.scala:
##########
@@ -298,7 +298,12 @@ class KyuubiSessionImpl(
}
override def getInfo(infoType: TGetInfoType): TGetInfoValue = {
- sessionConf.get(SERVER_INFO_PROVIDER) match {
+ // SERVER_INFO_PROVIDER is `.serverOnly`, so KyuubiConf.getUserDefaults
strips it from
+ // sessionConf. Unless the client set it explicitly for this session, fall
back to the
+ // server-level conf so the operator's kyuubi-defaults.conf setting is
honored.
+ val provider = sessionConf.getOption(SERVER_INFO_PROVIDER.key)
+ .getOrElse(sessionManager.getConf.get(SERVER_INFO_PROVIDER))
+ provider match {
Review Comment:
Agreed — cleaner. `kyuubi.server.info.provider` is only consumed by
KyuubiSessionImpl#getInfo, never by the engine, so dropping serverOnly is safe.
Reverted the getInfo change, removed the flag, and added
KyuubiServerInfoProviderSuite.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
