Sunwoo-Shin opened a new pull request, #7519:
URL: https://github.com/apache/kyuubi/pull/7519

   ### Why are the changes needed?
   
   Closes #7435.
   
   `kyuubi.server.info.provider` is declared `.serverOnly`, so 
`KyuubiConf#getUserDefaults` strips it from the per-session conf that 
`KyuubiSessionManager#openSession` builds. As a result 
`KyuubiSessionImpl#getInfo` reads it through 
`sessionConf.get(SERVER_INFO_PROVIDER)`, which never sees the server-level 
value and always returns the hard-coded default `ENGINE`. Setting 
`kyuubi.server.info.provider=SERVER` in `kyuubi-defaults.conf` is therefore 
silently ignored, and every `GetInfo` request waits for the engine to launch 
and forwards to it instead of being answered by the server directly.
   
   The fix reads the value from the session conf first — so an explicit 
per-session override still wins — and falls back to the server-level conf when 
the serverOnly entry was stripped. The `.serverOnly` semantics (never propagate 
the key to the engine) are unchanged; only the read site is fixed.
   
   Affected versions: 1.11.1.
   
   ### How was this patch tested?
   
   Added `KyuubiServerInfoProviderSuite`, which boots a server with 
`kyuubi.server.info.provider=SERVER` set only at the server level (no 
per-session override) and asserts `GetInfo(CLI_DBMS_NAME)` returns `Apache 
Kyuubi`. Before the fix it returns the engine name (`Spark SQL`).
   
   ```
   build/mvn test -pl kyuubi-server -am \
     -Dtest=none \
     -DwildcardSuites=org.apache.kyuubi.operation.KyuubiServerInfoProviderSuite
   ```
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   Assisted-by: Claude:claude-opus-4-8
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to