wangzhigang1999 commented on PR #7474:
URL: https://github.com/apache/kyuubi/pull/7474#issuecomment-4561638250
@aajisaka thanks, pushed the assumeFalse(X.isEmpty(), ...) change at both
call sites.
While in there I also swept the migrated tests for a few related JUnit 5
idiom polish-ups:
- assertTrue(x instanceof Y) → assertInstanceOf(Y.class, x) (and used its
return value to drop the redundant cast)
- try { ... ; fail(...) } catch (E) { } → assertThrows
- native assert (silently skipped without -ea) → JUnit assertions
- Assertions.X(...) → static-import form, matching the rest of the suite
All touched tests pass locally, including the live LLM suite.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
