wangzhigang1999 commented on code in PR #7474:
URL: https://github.com/apache/kyuubi/pull/7474#discussion_r3300961675
##########
pom.xml:
##########
@@ -175,6 +175,7 @@
<jetty.version>9.4.57.v20241219</jetty.version>
<jline.version>2.14.6</jline.version>
<junit.version>4.13.2</junit.version>
Review Comment:
Good point. The remaining direct `junit 4.x` usage is only in
`kyuubi-hive-beeline`.
I initially kept it on JUnit 4 because this module was forked from Apache
Hive 3.1.3 in #6109, but after checking the history, it has diverged since then
and we do not appear to sync it from upstream Hive anymore. So keeping JUnit 4
just for upstream alignment is not a strong reason.
WDYT? Should we migrate `kyuubi-hive-beeline` as well and remove the direct
JUnit 4 dependency/version entirely in this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
