pan3793 commented on code in PR #7417:
URL: https://github.com/apache/kyuubi/pull/7417#discussion_r3167644894
##########
externals/kyuubi-data-agent-engine/pom.xml:
##########
@@ -50,45 +50,63 @@
<version>${project.version}</version>
</dependency>
+ <!-- OpenAI official Java SDK -->
Review Comment:
let's currently manage kotlin and okhttp version in the data engine module's
`pom.xml`
> Just curious — what's the specific concern with introducing kotlin runtime?
1. Compatibility, Kotlin does not have LTS version, it just releases new
versions, and the previous version becomes EOL quickly, there is no explicit
compatibility guarantee.
2. Cross-language invocation is a horrible experience, though Kotlin is more
Java-friendly than Scala.
3. Shading/relocation of a language runtime lib is risky, which is required
for engines like Spark/Flink to avoid conflicts, especially `kotlin-reflect`, I
don't think we have such a JVM language expert resource to handle issues caused
by shading and relocation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
