wangzhigang1999 commented on code in PR #7417:
URL: https://github.com/apache/kyuubi/pull/7417#discussion_r3167445601
##########
externals/kyuubi-data-agent-engine/pom.xml:
##########
@@ -50,45 +50,63 @@
<version>${project.version}</version>
</dependency>
+ <!-- OpenAI official Java SDK -->
Review Comment:
I verified the actual `dist/` layout — multiple okhttp versions across
engines is already the status quo on master, and each engine runs as its own
JVM, so they never conflict at runtime.
The real question is whether we're okay introducing kotlin runtime for the
first time. I audited the full `dist/` — kotlin jars (~6MB) exist only in
`dist/externals/engines/data-agent/`, no leakage into server or other engines.
I surveyed alternative Java OpenAI clients (simple-openai, TheoKanning,
langchain4j, azure-openai, spring-ai) — under Java 8 + Apache-compatible
license + no-kotlin, none of them work. The only alternative is rolling our own
thin client over Apache HttpClient, which is non-trivial (SSE streaming,
tool-call serialization, retries).
Just curious — what's the specific concern with introducing kotlin runtime?
If it's classpath pollution, the engine isolation already prevents that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
