wangzhigang1999 commented on PR #7419: URL: https://github.com/apache/kyuubi/pull/7419#issuecomment-4343555626
Going to close this PR — the discussion drifted from the actual root cause, and the substitution mechanism here turned out to be unnecessary as you pointed out. Apologies for the noise on this thread; I should have traced the failure path empirically much earlier instead of arguing from incomplete reasoning, and I appreciate your patience walking me back to it. I'll open a new PR taking the direction you've been suggesting all along: align the dialect API with JDBC semantics by migrating the hand-written SQL methods (`getCatalogsOperation` / `getSchemasOperation` / `getTablesQuery` / `getColumnsQuery` / etc.) to call `connection.getMetaData.getXxx(...)` directly, plus implement `setSchema` at session open so the URL-scoped database is honored on the connection. That's both more uniform and properly fixes KYUUBI-7305 — DBeaver gets a real catalog/schema list back instead of `featureNotSupported`, and stops falling back to `getTables(null, null, ...)`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
