wangzhigang1999 commented on PR #7419: URL: https://github.com/apache/kyuubi/pull/7419#issuecomment-4342469015
Happy to do the refactor first if that's the preferred order. One thing to confirm though, since I want to make sure we're aligned: as I noted above, the URL-database routing (`effectiveDatabase` substitution when the client sends `null` / `"%"` schemaPattern) is still required after the refactor — verified empirically on mysql-connector-j 8.4.0, where `conn.getMetaData.getTables(null, "%", "%", null)` on a connection opened against `/dbA` still returns tables from all DBs. The refactor cleans up the SQL-string dialect methods but does not subsume this fix. Given that, do you still prefer refactor-first, or merge this as the minimal bug fix and follow up with the refactor? Either order works for me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
