Vladsz83 commented on code in PR #13577:
URL: https://github.com/apache/ignite/pull/13577#discussion_r4155591975
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/IncrementalSnapshotProcessor.java:
##########
@@ -138,7 +138,8 @@ void process(
WALRecord rec = walRec.getValue();
- if (rec.type() == CLUSTER_SNAPSHOT &&
((ClusterSnapshotRecord)rec).clusterSnapshotName().equals(sft.name())) {
+ // A filesystem might not support the character case of
directory or file name.
+ if (rec.type() == CLUSTER_SNAPSHOT &&
((ClusterSnapshotRecord)rec).clusterSnapshotName().equalsIgnoreCase(sft.name()))
{
Review Comment:
We know. Many snapshot operations doesn't support case insensitivity. This
is current limitation. We have tests for such cases. Bringing
filesystem-aware/path-aware comparison everywhere is out of scope of this
ticket.
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotCheckProcess.java:
##########
@@ -487,12 +489,17 @@ private IgniteInternalFuture<SnapshotCheckResponse>
prepareAndCheckMetas(UUID ig
if (nodeStopping)
return new GridFinishedFuture<>(new NodeStoppingException("The
node is stopping: " + kctx.localNodeId()));
- ctx = contexts.computeIfAbsent(req.snapshotName(), snpName -> new
SnapshotCheckContext(req));
+ ctx =
contexts.computeIfAbsent(req.snapshotName().toLowerCase(Locale.ROOT), snpName
-> new SnapshotCheckContext(req));
Review Comment:
We know. Many snapshot operations doesn't support case insensitivity. This
is current limitation. We have tests for such cases. Bringing
filesystem-aware/path-aware comparison everywhere is out of scope of this
ticket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
