Vladsz83 commented on code in PR #13577:
URL: https://github.com/apache/ignite/pull/13577#discussion_r4155588446
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/IgniteSnapshotManager.java:
##########
@@ -1478,8 +1605,11 @@ public boolean isRestoring() {
* @param snpName Snapshot name.
* @return {@code True} if the snapshot restore operation from the
specified snapshot is in progress locally.
*/
- public boolean isRestoring(String snpName) {
- return snpName.equals(restoreCacheGrpProc.restoringSnapshotName());
+ public boolean isRestoring(@Nullable String snpName) {
+ if (snpName == null)
+ return false;
+
+ return
snpName.equalsIgnoreCase(restoreCacheGrpProc.restoringSnapshotName());
Review Comment:
We know. Many snapshot operations doesn't support case insensitivity. This
is current limitation. We have tests for such cases. Bringing
filesystem-aware/path-aware comparison everywhere is out of scope of this
ticket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
