zstan commented on code in PR #13602:
URL: https://github.com/apache/ignite/pull/13602#discussion_r4104569613
##########
modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/integration/CacheStoreTest.java:
##########
@@ -150,6 +168,12 @@ public void testCacheStoreOnDML() throws Exception {
checkReadThrough(1002, 1003, 1004);
}
+ /** */
+ @Override protected List<List<?>> sql(IgniteEx ignite, String sql,
Object... params) {
+ return ignite.context().query().querySqlFields(new
SqlFieldsQuery(sql).setArgs(params), true)
Review Comment:
java doc says no:
```
* Since all the results will be fetched, all the resources will be
closed
* automatically after this call, e.g. there is no need to call {@link
#close()} method in this case.
*
* @return List containing all query results.
*/
public List<T> getAll();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
