zstan commented on code in PR #13602:
URL: https://github.com/apache/ignite/pull/13602#discussion_r4104290450
##########
modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/integration/CalcitePlanningDumpTest.java:
##########
@@ -19,27 +19,27 @@
package org.apache.ignite.internal.processors.query.calcite.integration;
import java.util.stream.Stream;
-
import org.apache.calcite.plan.RelOptPlanner;
import org.apache.calcite.rel.RelCollation;
import org.apache.ignite.internal.processors.query.QueryUtils;
import org.apache.ignite.internal.processors.query.calcite.schema.IgniteTable;
import org.apache.ignite.internal.util.typedef.X;
-import org.apache.ignite.testframework.junits.WithSystemProperty;
-import org.junit.Test;
-
-import static org.apache.ignite.IgniteCommonsSystemProperties.getLong;
+import org.apache.ignite.testframework.junit.SystemPropertiesExtension;
+import org.apache.ignite.testframework.junit.WithSystemProperty;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.ExtendWith;
import static
org.apache.ignite.internal.processors.query.calcite.CalciteQueryProcessor.IGNITE_CALCITE_PLANNER_TIMEOUT;
import static
org.apache.ignite.testframework.GridTestUtils.assertThrowsWithCause;
/**
* This test assumes no Calcite classes are loaded in the current JVM before
CalciteQueryProcessor.
* Violating this invariant may cause the test to fail due to premature
Calcite initialization.
*/
+@ExtendWith(SystemPropertiesExtension.class)
@WithSystemProperty(key = IGNITE_CALCITE_PLANNER_TIMEOUT, value = "1000")
public class CalcitePlanningDumpTest extends AbstractBasicIntegrationTest {
/** */
- private static final long PLANNER_TIMEOUT =
getLong(IGNITE_CALCITE_PLANNER_TIMEOUT, 0);
+ private static final long PLANNER_TIMEOUT = 1000L;
Review Comment:
fixed, thanks i miss it
##########
modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/integration/ViewsIntegrationTest.java:
##########
@@ -51,9 +52,19 @@ public class ViewsIntegrationTest extends
AbstractMultiEngineIntegrationTest {
}
/** {@inheritDoc} */
- @Override protected void afterTest() throws Exception {
- super.afterTest();
+ @BeforeEach
+ @Override protected void beforeTest() throws Exception {
+ persistenceEnabled = false;
+
+ assert G.allGrids().isEmpty() : "Not all Ignite instances stopped
before tests execution:" + G.allGrids();
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
