tmgodinho commented on code in PR #7639:
URL: https://github.com/apache/ignite-3/pull/7639#discussion_r2832982901
##########
modules/schema/src/main/java/org/apache/ignite/internal/schema/Column.java:
##########
@@ -246,6 +251,14 @@ private <T extends Comparable<T>> void checkBounds(T
value, T min, T max) {
}
}
+ private void checkPrecision(BigDecimal val) throws SchemaMismatchException
{
+ DecimalNativeType dnt = (DecimalNativeType) type;
Review Comment:
I don't think so, we have:
https://github.com/apache/ignite-3/blob/579169624e2fb211d2e9469e6a591169579cf679/modules/schema/src/main/java/org/apache/ignite/internal/schema/Column.java#L219-L221
before the bound validations.
Moreover, the other bound validations are also casting explicitly:
https://github.com/apache/ignite-3/blob/579169624e2fb211d2e9469e6a591169579cf679/modules/schema/src/main/java/org/apache/ignite/internal/schema/Column.java#L236-L244
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
