ptupitsyn commented on code in PR #7639:
URL: https://github.com/apache/ignite-3/pull/7639#discussion_r2832814787
##########
modules/schema/src/main/java/org/apache/ignite/internal/schema/Column.java:
##########
@@ -246,6 +251,14 @@ private <T extends Comparable<T>> void checkBounds(T
value, T min, T max) {
}
}
+ private void checkPrecision(BigDecimal val) throws SchemaMismatchException
{
+ DecimalNativeType dnt = (DecimalNativeType) type;
Review Comment:
Can this cast fail in some case?
##########
modules/schema/src/main/java/org/apache/ignite/internal/schema/row/RowAssembler.java:
##########
@@ -361,11 +360,6 @@ public RowAssembler appendDecimalNotNull(BigDecimal val)
throws SchemaMismatchEx
DecimalNativeType type = (DecimalNativeType) col.type();
- BigDecimal scaled = val.setScale(type.scale(), RoundingMode.HALF_UP);
Review Comment:
Was there a test for this removed behavior that still passes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
